Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverted condition when unwrapping lightmap #84374

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix inverted condition when unwrapping lightmap #84374

merged 1 commit into from
Nov 3, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Nov 2, 2023 •
edited
Loading

Condition checking for the presence of normals was inverted, it now matches the same check in lightmap_gi.cpp

@AThousandShips AThousandShips added this to the 4.2 milestone Nov 2, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner November 2, 2023 17:34
@YuriSizov YuriSizov mentioned this pull request Nov 2, 2023
Merged
SaracenOne
SaracenOne approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Silly mistake on behalf. LGTM 👍

@YuriSizov YuriSizov merged commit 64705bc into godotengine:master Nov 3, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips AThousandShips deleted the format_fix branch November 3, 2023 12:03
@AThousandShips
Copy link
Member Author

Thank you!

@Yagich Yagich mentioned this pull request Nov 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Regression in lightmap UV unwrapping in godot 4.2.beta4
3 participants
@AThousandShips @YuriSizov @SaracenOne