Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PackedArray to the list of enforcing Discrete for AnimationMixer #84390

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add PackedArray to the list of enforcing Discrete for AnimationMixer #84390

merged 1 commit into from
Nov 3, 2023

Conversation

TokageItLab
Copy link
Member

Follow up #83030.

Array and PackedArray are different Variant types, so they had to be added separately.

@TokageItLab TokageItLab added this to the 4.2 milestone Nov 3, 2023
@TokageItLab TokageItLab requested a review from a team as a code owner November 3, 2023 00:37
SaracenOne
SaracenOne approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes sense to me 👍

@YuriSizov YuriSizov merged commit f1426a5 into godotengine:master Nov 3, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@TokageItLab TokageItLab deleted the patch-packed-array-anim branch February 14, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug regression topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@TokageItLab @YuriSizov @SaracenOne