Add anti alias support for linear Canvasitem draw primitives #84497

xiongyaohua · 2023-11-06T02:06:26Z

(This PR is an follow-up for #84472, kept as draft for now. see #84472 (comment))

Add anti alias to the following canvasitem draw primitives

unfilled circle and rect
multiline and dashed_line

func _draw():
	draw_circle(Vector2(100,100), 100, Color.BROWN, false, 10)
	draw_circle(Vector2(100,400), 100, Color.BROWN, false, 10, true)
	
	draw_rect(Rect2(400, 0, 200, 200), Color.AQUA, false, 10)
	draw_rect(Rect2(400, 300, 200, 200), Color.AQUA, false, 10, true)
	
	draw_dashed_line(Vector2(700, 0), Vector2(900, 200), Color.CADET_BLUE, 10, 20, true)
	draw_dashed_line(Vector2(700, 50), Vector2(900, 250), Color.CADET_BLUE, 10, 20, true, true)

Make it possible to draw unfilled circle, like draw_rect().

- unfilled rect and circle - multiline and dashed_line

MewPurPur · 2024-01-08T12:55:38Z

doc/classes/CanvasItem.xml

+				Draws a circle. See also [method draw_arc], [method draw_polyline] and [method draw_polygon].	
+				If [param filled] is [code]true[/code], the cricle will be filled with the [param color] specified. If [param filled] is [code]false[/code], the circle will be drawn as a stroke with the [param color] and [param width] specified.
+				If [param width] is negative, then two-point primitives will be drawn instead of a four-point ones. This means that when the CanvasItem is scaled, the lines will remain thin. If this behavior is not desired, then pass a positive [param width] like [code]1.0[/code].
+				[b]Note:[/b] [param width] and [param antialiased] is only effective if [param filled] is [code]false[/code].


MewPurPur · 2024-01-08T12:56:40Z

doc/classes/CanvasItem.xml

 			<description>
 				Draws a rectangle. If [param filled] is [code]true[/code], the rectangle will be filled with the [param color] specified. If [param filled] is [code]false[/code], the rectangle will be drawn as a stroke with the [param color] and [param width] specified. See also [method draw_texture_rect].
 				If [param width] is negative, then two-point primitives will be drawn instead of a four-point ones. This means that when the CanvasItem is scaled, the lines will remain thin. If this behavior is not desired, then pass a positive [param width] like [code]1.0[/code].
-				[b]Note:[/b] [param width] is only effective if [param filled] is [code]false[/code].
+				[b]Note:[/b] [param width] and [param antialiased] is only effective if [param filled] is [code]false[/code].


MewPurPur · 2024-01-09T10:39:47Z

Could you show how antialiased multiline looks? I'm also interested in how transparency affects its drawing

xiongyaohua · 2024-01-19T01:41:59Z

@MewPurPur The multiline drawing behaviour should be identical to the original line. Here are some examples.

func _draw():
	var points := [
		Vector2(100, 100),
		Vector2(200, 200),
		Vector2(400, 100),
		Vector2(500, 200),
	]
	var colors :=  [
		Color(1,0.5,0.5,0.2),
		Color(1,0.5,0.5,0.4),
		Color(1,0.5,0.5,0.6),
		Color(1,0.5,0.5,0.8)
	]
	#draw_multiline_colors(points, colors, 10, false)
	for i in range(4):
		var new_points := points.map(func(v): return v+Vector2(0, 30*i))
		draw_polyline_colors(new_points, colors, 2 + i*2, false)
		new_points = points.map(func(v): return v+Vector2(0, 200 + 30*i))
		draw_polyline_colors(new_points, colors, 2 + i*2, true)
		
		new_points = points.map(func(v): return v+Vector2(600, 30*i))
		draw_multiline_colors(new_points, [colors[3]], 2 + i*2, false)
		new_points = points.map(func(v): return v+Vector2(600, 200 + 30*i))
		draw_multiline_colors(new_points, [colors[3]], 2 + i*2, true)

Original Size:

Enlarged:

MewPurPur

Reviewed the code, looks good to me.

MewPurPur · 2024-04-26T22:55:57Z

Any updates on this?

AThousandShips · 2024-04-27T07:42:22Z

It's intended as a follow-up to a PR that hasn't been merged yet, so see:

Extend CanvasItem::draw_circle(), making it also draw unfilled circle. #84472

Calinou

Tested locally (rebased on top of master 6118592), it works as expected in all rendering methods.

Testing project: test-antialiased-rect-line.zip

Remember to add GDExtension compatibility methods as you did in #84472.

Calinou · 2024-05-02T22:59:53Z

@xiongyaohua Now that #84472 has been merged, you should be able to rebase this PR onto the latest master branch.

xiongyaohua · 2024-05-09T04:54:55Z

@Calinou will do in the next week. And thanks for the test.

Now that #84472 has been merged, you should be able to rebase this PR onto the latest master branch.

xiongyaohua · 2024-05-09T12:42:14Z

I'm going to close this PR, as all codes are incorporated into the following PR #84523. Review can be done over there.

xiongyaohua added 2 commits November 5, 2023 20:47

Extend CanvasItem::draw_circle()

18493f3

Make it possible to draw unfilled circle, like draw_rect().

Add antialiased support for some canvas items

d74e490

- unfilled rect and circle - multiline and dashed_line

xiongyaohua requested review from a team as code owners November 6, 2023 02:06

xiongyaohua mentioned this pull request Nov 6, 2023

Extend CanvasItem::draw_circle(), making it also draw unfilled circle. #84472

Merged

xiongyaohua changed the title ~~Add anti alias support for linear canvas items~~ Add anti alias support for linear Canvasitem draw primitives Nov 6, 2023

Calinou added enhancement topic:rendering topic:2d labels Nov 6, 2023

xiongyaohua mentioned this pull request Nov 6, 2023

CanvasItem draw implement antialiasing for circle, rect, multiline, and dashedline #84523

Merged

AThousandShips added this to the 4.x milestone Nov 7, 2023

xiongyaohua marked this pull request as draft November 8, 2023 02:55

MewPurPur mentioned this pull request Nov 15, 2023

GodSVG Optimization roadmap MewPurPur/GodSVG#212

Closed

MewPurPur reviewed Jan 9, 2024

View reviewed changes

MewPurPur approved these changes Jan 19, 2024

View reviewed changes

Calinou reviewed Apr 28, 2024

View reviewed changes

xiongyaohua closed this May 9, 2024

AThousandShips added the archived label May 9, 2024

AThousandShips removed this from the 4.x milestone May 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add anti alias support for linear Canvasitem draw primitives #84497

Add anti alias support for linear Canvasitem draw primitives #84497

xiongyaohua commented Nov 6, 2023 •

edited

Loading

MewPurPur Jan 8, 2024

MewPurPur Jan 8, 2024

MewPurPur commented Jan 9, 2024 •

edited

Loading

xiongyaohua commented Jan 19, 2024 •

edited

Loading

MewPurPur left a comment •

edited

Loading

MewPurPur commented Apr 26, 2024

AThousandShips commented Apr 27, 2024

Calinou left a comment •

edited

Loading

Calinou commented May 2, 2024

xiongyaohua commented May 9, 2024 •

edited

Loading

xiongyaohua commented May 9, 2024

Add anti alias support for linear Canvasitem draw primitives #84497

Add anti alias support for linear Canvasitem draw primitives #84497

Conversation

xiongyaohua commented Nov 6, 2023 • edited Loading

MewPurPur Jan 8, 2024

Choose a reason for hiding this comment

MewPurPur Jan 8, 2024

Choose a reason for hiding this comment

MewPurPur commented Jan 9, 2024 • edited Loading

xiongyaohua commented Jan 19, 2024 • edited Loading

MewPurPur left a comment • edited Loading

Choose a reason for hiding this comment

MewPurPur commented Apr 26, 2024

AThousandShips commented Apr 27, 2024

Calinou left a comment • edited Loading

Choose a reason for hiding this comment

Calinou commented May 2, 2024

xiongyaohua commented May 9, 2024 • edited Loading

xiongyaohua commented May 9, 2024

xiongyaohua commented Nov 6, 2023 •

edited

Loading

MewPurPur commented Jan 9, 2024 •

edited

Loading

xiongyaohua commented Jan 19, 2024 •

edited

Loading

MewPurPur left a comment •

edited

Loading

Calinou left a comment •

edited

Loading

xiongyaohua commented May 9, 2024 •

edited

Loading