Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autocompletion for enum members in the core classes #84532

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Nov 6, 2023

My attempt to fix #84509

изображение

PS: Also fixed the completion of inner classes (where only the enums or subclasses should be returned)

изображение

@Chaosus Chaosus requested a review from a team as a code owner November 6, 2023 16:10
@Chaosus Chaosus added this to the 4.3 milestone Nov 6, 2023
@Chaosus Chaosus force-pushed the gds_fix_autocompletion branch 2 times, most recently from 50ac50b to 34576df Compare November 6, 2023 16:29
@Chaosus Chaosus force-pushed the gds_fix_autocompletion branch 5 times, most recently from 5bbaea4 to d046be3 Compare November 30, 2023 13:37
@Chaosus Chaosus requested a review from Calinou December 13, 2023 12:37
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Needs a rebase before it can be merged.

simplescreenrecorder-2024-02-05_23.51.36.mp4

@Chaosus Chaosus force-pushed the gds_fix_autocompletion branch from d046be3 to 076c64e Compare February 7, 2024 17:15
@Chaosus
Copy link
Member Author

Chaosus commented Feb 7, 2024

Rebased*.

@Chaosus Chaosus force-pushed the gds_fix_autocompletion branch from 076c64e to 76ea8a0 Compare February 7, 2024 17:31
@Chaosus Chaosus force-pushed the gds_fix_autocompletion branch from 76ea8a0 to 1d75480 Compare February 7, 2024 17:42
@akien-mga akien-mga merged commit 35cfbdd into godotengine:master Feb 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the gds_fix_autocompletion branch February 8, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion does not work for the core class enums
4 participants