-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details about AudioEffectCapture.clear_buffer()
and get_buffer()
#84584
Conversation
AudioEffectCapture.clear_buffer()
and get_buffer()
When you make further changes, could you please squash your commits into one? Make sure that the final commit has a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing. |
Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
@YuriSizov it started out as a single commit, but several modifications were suggested in the pull request and a I accepted them. The github UI did not offer me a squash option. |
Please see the documentation above, you need to use the command line I can help you if you are not able to do so yourself |
3da6b6b
to
e9a280d
Compare
You changed previous commits incorrectly, you need to remove those, this is because you resigned them with your own user You should also start your commit with a capital letter |
e9a280d
to
4ca2c73
Compare
To drop those commits you need to do |
4ca2c73
to
a1ac966
Compare
@lyuma if your interested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The details look good on paper but we need feedback from audio-savvy developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first section looks ok to me, I haven't checked the math for get_buffer. Will ping @lyuma
a1ac966
to
182b9ef
Compare
I pushed a doc update as suggested. @mutantbob For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
Thanks! And congrats for your first merged Godot contribution 🎉 |
This adds a few sentences to the AudioEffectCapture.xml documentation with helpful notes about the clear_buffer() and get_buffer() functions.
It does not fully address issue godotengine/godot-docs#8326 , but should be useful to new users.