Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CollisionObject3D Gizmo not updated after calling shape_owner_* functions #84610

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix CollisionObject3D Gizmo not updated after calling shape_owner_* functions #84610

merged 1 commit into from
Jan 17, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #84540

Two things to disscuss:

  1. potential performance problem because of additional calls to update_gizmo
  2. Is there any other defered gizmo update call be immediate

@jsjtxietian jsjtxietian marked this pull request as ready for review November 8, 2023 09:53
@jsjtxietian jsjtxietian requested a review from a team as a code owner November 8, 2023 09:53
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 8, 2023
@Calinou Calinou added topic:editor cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 8, 2023
@akien-mga akien-mga changed the title Fix CollisionObject3D Gizmo not updated after calling shape_owner_* functions Fix CollisionObject3D Gizmo not updated after calling shape_owner_* functions Jan 9, 2024
KoBeWi
KoBeWi approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potential performance problem because of additional calls to update_gizmo

update_gizmos() code only runs in editor builds, so it's a non-issue.

@jsjtxietian jsjtxietian force-pushed the update-gizmo-right-after-assign branch from 922be8f to 80a488a Compare January 17, 2024 02:43
@YuriSizov YuriSizov merged commit 2e1f4f4 into godotengine:master Jan 17, 2024
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@jsjtxietian jsjtxietian deleted the update-gizmo-right-after-assign branch January 19, 2024 03:24
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 24, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
bug topic:editor topic:physics topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

CollisionObject3D Gizmo not updated after changing collision with shape_owner_* functions in a @tool script
6 participants
@jsjtxietian @YuriSizov @KoBeWi @akien-mga @Calinou @AThousandShips