Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about autowrapped labels in containers #84662

Merged

Conversation

YuriSizov
Copy link
Contributor

Adds a warning for cases like #83546, until we fix the sizing model for autowrapped nodes.

@YuriSizov YuriSizov added this to the 4.2 milestone Nov 9, 2023
@YuriSizov YuriSizov requested a review from a team as a code owner November 9, 2023 13:12
scene/gui/label.cpp Outdated Show resolved Hide resolved
scene/gui/label.cpp Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

akien-mga commented Nov 9, 2023

Seems to work well on a scene which I spent 1 hour debugging yesterday to find the problem:
image

So this will be quite useful for others too I believe.

@KoBeWi
Copy link
Member

KoBeWi commented Nov 9, 2023

You can also set EXPAND_FILL and it will work too (depending on the container). Minimum size is not always a requirement.

@YuriSizov
Copy link
Contributor Author

You can also set EXPAND_FILL and it will work too (depending on the container). Minimum size is not always a requirement.

This is not a guarantee. The issue comes from minimum size computations, whereas the size flags are only considered when fitting children.

@akien-mga akien-mga merged commit f7a7015 into godotengine:master Nov 9, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants