Prevent crash on conversion of invalid data in Image

[rsburke4]

Added error to address #84750

Bugsquad edit:

• Fix Executing Image.convert function crashes Godot #84750

[AThousandShips]

Thank you for your contribution

This wouldn't be sufficient, it won't always catch the negative case as the check above is checking for positive values

I'd suggest (as I did in the issue report) to check the type, look in _initialize_data, add this at the top of the convert function instead: ERR_FAIL_INDEX_MSG(p_new_format, FORMAT_MAX, "The Image format specified (" + itos(p_new_format) + ") is out of range. See Image's Format enum.");

After the check for p_new_format == format (line 519)

Edit: note also that the check added is in reverse, it requires that the data be empty, the error macros checks if the condition is true and if it is the error is thrown

[AThousandShips]

I'd also suggest adding a test for this invalid use to the unit tests, in file tests/core/io /test_image.h

[rsburke4]

Thank you for your help and clarification. I think I understand a little better now. Would this suffice for a test case? It seems to catch problems and print a helpful errors when it fails.

[AThousandShips]

These tests are good but doesn't cover that it safely handles invalid ones

[AThousandShips]

I don't have an ASAN build to confirm this but the tests pass and the check works otherwise, preventing some spurious errors

Can someone with an ASAN build confirm in addition to the unit tests?

Just some minor style fixes

[YuriSizov]

@rsburke4 Are you around to address the latest style suggestions? 🙃

[rsburke4]

Yes, I will make the adjustment today. Thank you.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[YuriSizov]

Cherry-picked for 4.2.2.

[YuriSizov]

Cherry-picked for 4.1.4.