Fix memory leak in 'NavigationServer3D' involving static obstacles #84816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scony
force-pushed
the
add-obstacle-navserver-tests
branch
from
06ccc8c to
f832a03
Compare
Scony
force-pushed
the
add-obstacle-navserver-tests
branch
from
f832a03 to
776e298
Compare
Scony
changed the title
Scony
force-pushed
the
add-obstacle-navserver-tests
branch
from
776e298 to
1be3997
Compare
|
@akien-mga this PR is now a bugfix with tests - if you like I can extract tests to separate PR. |
smix8
approved these changes
Nov 17, 2023
akien-mga
added
the
cherrypick:4.2
Scony
force-pushed
the
add-obstacle-navserver-tests
branch
from
1be3997 to
a4b3546
Compare
AThousandShips
approved these changes
Nov 17, 2023
|
Thanks! |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was about adding further core tests for
NavigationServer3D, but it exposed quite a serious memory leak, so I've extended implementation to fix that.CC @smix8