Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donors: Change tiers to match Dev Fund, sync latest data #84884

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

akien-mga
Copy link
Member

The new list includes all donors listed on fund.godotengine.org, together with the ones still on Patreon on matching tiers.

We haven't yet updated Patreon tiers to match the Dev Fund, so donors who used to be listed under "Silver donors" are now grandfathered under the "Gold members" category from the Dev Fund.

simplescreenrecorder-2023-11-14_14.39.48.mp4

@akien-mga akien-mga added enhancement topic:buildsystem topic:editor cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 14, 2023
@akien-mga akien-mga added this to the 4.2 milestone Nov 14, 2023
@akien-mga akien-mga requested a review from a team as a code owner November 14, 2023 13:40
@adamscott
Copy link
Member

Should we fix the alphabetic ordering for the merges? It seems that there's two A-Z lists in Gold members.

@akien-mga
Copy link
Member Author

akien-mga commented Nov 14, 2023

Should we fix the alphabetic ordering for the merges? It seems that there's two A-Z lists in Gold members.

It's intentional, there are three sub-tiers listed under Gold currently:

  1. Gold Members from the Dev Fund, and matching $25 tier from Patreon (merged together), which is the new base tier for adding names to the credits
  2. $14/$18 tiers from Patreon merged as one, which used to be "your name in the credits, but higher up"
  3. $10 tier from Patreon ("your name in the credits")

We'll then update Patreon to sync the tiers on both platforms, so next update will see the removal of the <$25 tiers from that file.

@coppolaemilio
Copy link
Member

coppolaemilio commented Nov 14, 2023

I would maybe move the And x anonymous donors at the end of the list, but not really necessary.

@dsnopek
Copy link
Contributor

dsnopek commented Nov 14, 2023

Hm. A very personal question: this is removing me from the list of donors, but I'm still a donor, and I moved to the PayPal subscription some months ago. Did I miss a step for getting included in the list?

@YuriSizov
Copy link
Contributor

YuriSizov commented Nov 14, 2023

@dsnopek Either you are donating below the threshold (we list people from gold member and up) or you don't have your name specified, so you are listed under anonymous.

If it's neither of those, we also have reports from some users that they sporadically disappear from the list on the website (PayPal is probably bugging out), maybe you're just unlucky.

@@ -161,7 +161,8 @@ EditorAbout::EditorAbout() {

Label *about_text = memnew(Label);
about_text->set_v_size_flags(Control::SIZE_SHRINK_CENTER);
about_text->set_text(String::utf8("\xc2\xa9 2014-present ") + TTR("Godot Engine contributors") + "." +
about_text->set_text(
String::utf8("\xc2\xa9 2014-present ") + TTR("Godot Engine contributors") + "." +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's been like that before, but I find it weird that we translate that part specifically, but not, say, "present". 🙃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also dates themselves are subject to translation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could create a PR afterwards to translate that part of the string.

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

@dsnopek
Copy link
Contributor

dsnopek commented Nov 14, 2023

@YuriSizov I see now on https://fund.godotengine.org/ that I was supposed to send an email to get my name listed. Per my PayPal history, I moved my subscription from Patreon to PayPal back in March, and I guess I wasn't aware of that requirement. I've just sent the email, so I'll hopefully get included in the next update. :-)

@akien-mga akien-mga force-pushed the donors-sync-new-tiers branch from 9ecf57c to fee03d3 Compare November 14, 2023 14:40
The new list includes all donors listed on fund.godotengine.org,
together with the ones still on Patreon on matching tiers.

We haven't yet updated Patreon tiers to match the Dev Fund, so donors
who used to be listed under "Silver donors" are now grandfathered under
the "Gold members" category from the Dev Fund.
@akien-mga akien-mga force-pushed the donors-sync-new-tiers branch from fee03d3 to ff5ac86 Compare November 14, 2023 14:40
@akien-mga
Copy link
Member Author

@dsnopek Added you back here, until Emi adds you to the fund :)

@coppolaemilio
Copy link
Member

Added on the dev fund!

@akien-mga akien-mga merged commit dcee5cf into godotengine:master Nov 14, 2023
15 checks passed
@akien-mga akien-mga deleted the donors-sync-new-tiers branch November 14, 2023 18:35
@akien-mga
Copy link
Member Author

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 16, 2024
@akien-mga
Copy link
Member Author

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 16, 2024
@akien-mga
Copy link
Member Author

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants