Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store ArrayMesh path in RenderingServer for use in error messages #84894

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

clayjohn
Copy link
Member

Fixes: #84875

This only works for ArrayMeshes and not for custom meshes created through the RenderingServer API (unless the uses sets the path manually).

Its the same approach we have used for textures and shaders, so it is nice to keep the API consistent.

@clayjohn clayjohn added enhancement topic:rendering usability cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 14, 2023
@clayjohn clayjohn added this to the 4.3 milestone Nov 14, 2023
@clayjohn clayjohn requested a review from a team as a code owner November 14, 2023 15:30
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

I wonder that if no file path is available, we could also check if the user has set a resource name. I know its not common for users to set that, but in case they do, it'll atleast give them a hint?

@YuriSizov YuriSizov merged commit 2ce450f into godotengine:master Jan 24, 2024
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

I wonder that if no file path is available, we could also check if the user has set a resource name. I know its not common for users to set that, but in case they do, it'll atleast give them a hint?

That makes sense to me, but I assume it also needs to be done to textures and shaders, so I think we can do this as a follow-up.

@alfredbaudisch
Copy link
Contributor

As of 4.2.2 RC 1, the issue of "Attempting to use a shader that requires tangents with a mesh that doesn't contain tangents." being spammed is still presently HEAVILY. Literally 1000s of these warning messages.

@akien-mga
Copy link
Member

That's expected, this PR was merged two weeks ago in the master branch (4.3.dev) and hasn't been cherrypicked for the 4.2 branch yet.

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants