Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transform sync in RigidBody*D::_body_state_changed #84924

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Nov 15, 2023

Fixes #84919.

This replaces the force_update_transform that was added as part of #84799 with the more crude solution of comparing the before-and-after of the global transform to determine whether we need to push any new updates to the physics server or not, thereby skirting around the problem of the global_invalid flag mentioned in #84856.

Note that this is not strictly necessary in the 3D bodies, as force_update_transform works just fine there, but I figured it's better to keep things consistent.

@akien-mga akien-mga merged commit e0707a0 into godotengine:master Nov 15, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RigidBody2D overwrites most transform changes done in _integrate_forces
4 participants