Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search/replace bar behavior #84932

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Improve search/replace bar behavior #84932

merged 1 commit into from
Apr 15, 2024

Conversation

timothyqiu
Copy link
Member

  • When multiple lines are selected before CTRL-F / CTRL-R:
    • Find: Keep previous search instead of putting the selected lines into the find input.
    • Replace: Focus find input instead of replace input.
  • Add placeholder and tooltip for the two LineEdits and icon buttons.
  • Disable related buttons when the operation makes no sense.

@timothyqiu timothyqiu added enhancement topic:editor usability cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Nov 15, 2023
@timothyqiu timothyqiu added this to the 4.3 milestone Nov 15, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner November 15, 2023 10:29
@timothyqiu
Improve search/replace bar behavior
bafbdc6 
- When multiple lines are selected:
  - Find: Keep previous search instead of putting those lines in the
    find input.
  - Replace: Focus find input instead of replace input.
- Add placeholder and tooltip for LineEdits and icon buttons.
- Disable related buttons when the operation makes no sense.
@timothyqiu timothyqiu requested a review from KoBeWi April 12, 2024 08:45
@timothyqiu timothyqiu removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 15, 2024
@timothyqiu timothyqiu requested a review from akien-mga April 15, 2024 06:19
@KoBeWi
Copy link
Member

KoBeWi commented Apr 15, 2024

Find: Keep previous search instead of putting the selected lines into the find input.

If we had multiline find, the old behavior wouldn't be bad.

@akien-mga akien-mga merged commit 5b681db into godotengine:master Apr 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the search-and-replace branch April 15, 2024 11:58
@timothyqiu timothyqiu mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

@akien-mga akien-mga Awaiting requested review from akien-mga

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @KoBeWi @akien-mga