Fix translation po file not found when make rst LANGARG=zh_CN
#85073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rindbee
changed the title
make rstmake rst LANGARG=zh_CN
Rindbee
force-pushed
the
fix-wrong-path-when-make-rst
branch
3 times, most recently
from
651faea to
46903f8
Compare
The parsed language parameters contain unstripped spaces. This will generate a wrong path. Provide a `TOOLSOPT` to allow overriding the default values of parameters of the `make_rst.py` script. The xml generated by `godot --doctool -l LANG` can be checked for errors using `make xml-check LANGARG=LANG`, which may be useful for checking errors in po files.
Rindbee
force-pushed
the
fix-wrong-path-when-make-rst
branch
from
46903f8 to
ed0e6e8
Compare
akien-mga
approved these changes
Nov 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsed language parameters contain unstripped spaces. This will generate a wrong path.
Before:
After:
Provide a
TOOLSOPTto allow overriding the default values of parameters of themake_rst.pyscript.The xml generated by
godot --doctool -l LANGcan be checked for errors usingmake xml-check LANGARG=LANG, which may be useful for checking errors in po files.