Make AMOUNT_RATIO constant in the shader language specification.
#85086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Writing to it doesn't do anything and will crash the compatibility backend.
Calinou
approved these changes
Nov 19, 2023
QbieShay
approved these changes
Nov 19, 2023
akien-mga
changed the title
AMOUNT_RATIO constant in the shader language specification.AMOUNT_RATIO constant in the shader language specification.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an unreported bug I noticed while updating the shader documentation.
In current master, writing to
AMOUNT_RATIOdoesn't do anything and will crash the compatibility backend.This is a very low risk PR. I suggest we merge it in the next RC so there is no perception of compatibility breakage if a user accidentally writes to
AMOUNT_RATIO(in the RD renderers).