Don't insert newline while saving #85228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jun 26, 2024
KoBeWi
force-pushed
the
don't_save_scene_when_saving_script_while_saving_scene
branch
from
3d05f72
to
b70368b
Compare
|
Thanks! |
KoBeWi
deleted the
don't_save_scene_when_saving_script_while_saving_scene
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #85154
Changes the new check into an error; saving while saving is now invalid behavior. I tweaked Script Editor to avoid the new error. There might be some cases when the newline is not applied correctly, but it's probably rare and harmless. Saving script in Script Editor does call
apply_changes().