-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lambda cross-thread dynamics (take 2) #85248
Merged
akien-mga
merged 2 commits into
godotengine:master
from
RandomShaper:fix_gdlamb_doublefree_2
Nov 23, 2023
Merged
Fix lambda cross-thread dynamics (take 2) #85248
akien-mga
merged 2 commits into
godotengine:master
from
RandomShaper:fix_gdlamb_doublefree_2
Nov 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
reviewed
Nov 23, 2023
RandomShaper
force-pushed
the
fix_gdlamb_doublefree_2
branch
from
November 23, 2023 09:25
edd80c1
to
a34aa4e
Compare
akien-mga
reviewed
Nov 23, 2023
RandomShaper
force-pushed
the
fix_gdlamb_doublefree_2
branch
from
November 23, 2023 09:37
a34aa4e
to
7e99a6e
Compare
YuriSizov
reviewed
Nov 23, 2023
YuriSizov
reviewed
Nov 23, 2023
YuriSizov
reviewed
Nov 23, 2023
YuriSizov
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RandomShaper
force-pushed
the
fix_gdlamb_doublefree_2
branch
from
November 23, 2023 17:50
7e99a6e
to
bfe66ab
Compare
akien-mga
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested successfully on a few projects using lambdas.
Thanks! |
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two commits:
Supersedes #85223.
Fixes #85151.
Tested the following recent related bugs are still gone after this PR (plus no address sanitizer issues detected);