Suppress surface upgrade warnings when showing SurfaceUpgradeTool warning #85249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning Also ensure the EditorProgress dialogue shows correct numbers
YuriSizov
approved these changes
Nov 23, 2023
akien-mga
approved these changes
Nov 23, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warning spam reported here: #85222 (comment)
The problem comes from the fact that the SurfaceUpgradeTool callback was called for each out of date surface and the old surface-specific warning was still shown to the user.
This PR ensures that, if the surface update callback is handled, the only warning shown to the user is the own pointing them at the SurfaceUpgradeTool. We don't need the old per-surface warning in this case as the user can fix all meshes by running the tool.
The RenderingServer still has the warning for cases where the scene is run outside the editor.
This also updates the EditorProgress dialogue that runs after the upgrade tool is run. Previously it would start at 100%, then run through re-saving all the files (locked at 100%), then would appear to freeze while deleting the .import files. Now it properly progresses through re-saving all the files, and shows progress while deleting files.