Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NavigationRegion2D transform update #85258

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Fix NavigationRegion2D transform update #85258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scene/2d/navigation_region_2d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ void NavigationRegion2D::_notification(int p_what) {

case NOTIFICATION_INTERNAL_PHYSICS_PROCESS: {
set_physics_process_internal(false);
_region_update_transform();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way internal physics process is used here as a one shot seems like a convoluted way to do a deferred call. I assume call deferred wouldn't be enough for this method in NOTOFICATION_TRANSFORM_CHANGED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly the reason this was added as a physics process one shot is because the server does the sync on the physics tick directly after this.

If it is added to the msg queue it would need a bool to stop the transform notification from spamming the msg queue like crazy which was one of the original problems. E.g. animationplayers that moved regions would trigger 1000+ transform update calls at high frame rate for every navigation server sync due to the lower physics tick rate.

} break;

case NOTIFICATION_DRAW: {
Expand Down
Loading