Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force ANGLE on all pre GCN 4th gen. AMD/ATI GPUs. #85273

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Force ANGLE on all pre GCN 4th gen. AMD/ATI GPUs. #85273

merged 1 commit into from
Dec 12, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 23, 2023 •
edited by adamscott
Loading

Fixes #78888
Fixes #85804

Production edit: added fix for #85804

@bruvzg bruvzg added this to the 4.x milestone Nov 23, 2023
@bruvzg bruvzg marked this pull request as ready for review December 4, 2023 06:06
@bruvzg bruvzg requested a review from a team as a code owner December 4, 2023 06:06
@adamscott adamscott added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Dec 6, 2023
@adamscott
Copy link
Member

Cherry-picking for 4.2, as it could fix #85804

adamscott
adamscott approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems more robust than previously.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Dec 6, 2023
@YuriSizov YuriSizov requested a review from a team December 8, 2023 15:38
@adamscott adamscott mentioned this pull request Dec 10, 2023
Closed
akien-mga
akien-mga approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on chat, it would be nice to find a place outside main.cpp to set all this Windows and GL Compatibility specific metadata. But this creates some architecture questions of where to put it exactly.

Should be fine as is for the time being.

@akien-mga akien-mga merged commit 7481132 into godotengine:master Dec 12, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

This was referenced Dec 13, 2023
Closed
Closed
@kleonc kleonc mentioned this pull request Jan 8, 2024
Closed
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga added platform:windows topic:porting and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement platform:windows topic:porting topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

AMD R5 M330 graphic issues Can't run Godot OpenGL 3 on ATI Radeon HD 3650 since shader cache addition
3 participants
@bruvzg @adamscott @akien-mga