Make sure Window's title is respected before we compute the size
#85312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes some suspicious and outdated code that forced this particular dialog to change size when the warning message changed.
YuriSizov
added
bug
platform:windows
topic:gui
cherrypick:4.2
bruvzg
approved these changes
Nov 25, 2023
|
Thanks! |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85118.
Like the title says, we used to first apply the size limit, and then we would update said limit without it affecting the actual size. So the window would be displayed with one size, and window's contents would refer to another size. Good old DisplayServer/Window de-sync.
It may not be Windows specific, as far as OSes go, highly depends on how window management is implemented on each platform. But since we are only reproducing it on Windows for now, I'm marking it as such. Also I guess we can say it's a regression because it's been introduced with the feature to keep the title visible in 4.2: #80409.
Also removes some suspicious and outdated code that forced this particular dialog to change size when the warning message changed.