[Core] Fix crash when hashing empty CharString
#85389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:core
crash
cherrypick:4.1
bruvzg
approved these changes
Nov 26, 2023
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
7 tasks
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal fix, could make
hash_djb2handlenullptrgracefully but limited it to fixing this direct issue here.get_dataalways returns a non-null pointer.hash_djb2is not used directly anywhere in the engine, onlyHashMapHasherDefaultuses it, though you could have issues if you feed it a plain string, but I don't know if that's a major risk here, I think it's fair to assume that these methods should be called with non-null arguments.If I am to change that to handle this gracefully I'd also change the
String::hashmethods taking a pointer as they all also assume it to be non-null.