-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PhysicsShapeQueryParameters3D.motion
type wrongly set to Vector2
#85393
Conversation
Need to add compatibility notice for this change, see
Unsure the details to add further, i.e. if some instructions are needed And once 4.2 has been released a 4.2 version of that will be added and you can add it to that |
Ahhh, thank you for the thorough explanation! Sorry for the trouble. 😅
So I shouldn't add it to the |
You can to get the CI finished, and then move it, or wait until after the new one has been added 🙂 |
You should be able to update your PR now, the required file has been added. 🙃 |
PhysicsShapeQueryParameters3D.motion
type binding
PhysicsShapeQueryParameters3D.motion
type bindingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased myself to add the compatibility statement.
Technically, this breaks compatibility AFAIK, but the previous binding was unusable.
Thanks! And congrats for your first merged Godot contribution 🎉 |
Oh wow! Sorry, it's been a busy couple weeks and this completely slipped my mind. 🙇🙇 |
PhysicsShapeQueryParameters3D.motion
type wrongly set to Vector2
Maybe I'm missing something, but according to the getter/setter and documentation, this should be a Vector3.