Fix IME key event being erased in macOS #85458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
platform:macos
topic:input
cherrypick:4.2
bruvzg
approved these changes
Nov 28, 2023
Fixes Korean IME behavior which calls insertText and setMarkedText at the same time.
HolySkyMin
force-pushed
the
mac_korean_fix
branch
from
3a1752a
to
5962e52
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes IME input in macOS, especially Korean IME which calls
insertTextandsetMarkedTextat the same time.Before:
2023-11-28.5.10.58.mov
After:
2023-11-28.5.09.57.mov
Bugsquad edit: