Fix horizontal scroll in editor's 2D view #85473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
|
Those are fair points. I simply hope no one use the thumb scrollwheel to zoom-in/out. |
|
You need to add similar changes in line 49. |
miv391
force-pushed
the
fix-horizontal-mouse-wheeling-in-2d-view
branch
from
00dda71 to
2f98e38
Compare
Fixed. |
KoBeWi
reviewed
Nov 28, 2023
miv391
force-pushed
the
fix-horizontal-mouse-wheeling-in-2d-view
branch
from
2f98e38 to
187bb61
Compare
KoBeWi
approved these changes
Nov 28, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #77212
Some mouses (for example Logitech G502) have wheels with horizontal scrolling feature. A slight horizonal click of wheel will send WHEEL_RIGHT and WHEEL_LEFT messages. When using the wheel for zooming (by rotating it, WHEEL_UP/WHEEL_DOWN) and clicking the wheel (for panning) it is very easy to unintentionally to activate the horizontal scrolling.
Currently horizontal scrolling in editor's 2D view causes zooming. No other view (3D, code) works like this. 2D view is pretty much unusable with a mouse which has horizontal scrolling feature, you are almost constantly doing unintentional zooming while trying to pan the view. In Godot 3.5 horizontal scrolling does not cause zooming in 2D view.
This PR fixes this problem by using only vertical scrolling for zooming.