Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Camera3D.current from being set to true automatically in the editor. #85594

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Prevent Camera3D.current from being set to true automatically in the editor. #85594

merged 1 commit into from
Dec 19, 2023

Conversation

addmix
Copy link
Contributor

@addmix addmix commented Dec 1, 2023

Fixes #85593

@addmix addmix requested a review from a team as a code owner December 1, 2023 08:41
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 1, 2023
@AThousandShips
Copy link
Member

Please update your commit message to be more informative, the title of the PR would be good

@addmix addmix force-pushed the camera3d-current-bug branch from a929504 to 5b5ac92 Compare December 1, 2023 09:51
@RedMser
Copy link
Contributor

RedMser commented Dec 1, 2023

Would the same fix need to be done for Camera2D? It also has "assign next camera as current" logic, looking at its code.

@YuriSizov YuriSizov requested a review from KoBeWi December 1, 2023 17:06
@addmix
Copy link
Contributor Author

addmix commented Dec 1, 2023

Would the same fix need to be done for Camera2D? It also has "assign next camera as current" logic, looking at its code.

I gave Camera2D a quick look, and I don't believe it needs the same fix, as Camera2D doesn't have the current property.

KoBeWi
KoBeWi approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, Camera2D doesn't need it. The logic is a bit different.

@YuriSizov YuriSizov merged commit 252c462 into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Camera3D.current is set to true when setting Camera3D.current to false on another node
5 participants
@addmix @AThousandShips @RedMser @YuriSizov @KoBeWi