Fix unnecessarily quantizing current color in color picker #85749
Conversation
|
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
bs-mwoerner
force-pushed
the
color_picker_quantize_fix
branch
from
170db96 to
1b85b8f
Compare
|
Oh, thanks for the heads-up! Should be linked to the correct account now. Thanks! |
akien-mga
added
bug
topic:gui
cherrypick:4.2
|
Good work catching the error in my pr. I think this pr could be better fit to be modified, and I don't currently have time to work on it, so feel free to borrow from my solution. |
I will, thanks! And I only caught that error because I spent quite some time pulling my hair out when I was working on my own PR wondering how on Earth it still managed to get the wrong color value through to the caller despite me having breakpoints everywhere. 😅 |
bs-mwoerner
force-pushed
the
color_picker_quantize_fix
branch
from
1b85b8f to
974656f
Compare
Made the HTML field send change events based on whether the new color's string is different from the previous color's string (instead of whether the new string parses to the current color value). Previously, updating the color value even when the corresponding string hadn't changed would unnecessarily quantize the color value to 8 bits just by opening/closing the Color Picker.
bs-mwoerner
force-pushed
the
color_picker_quantize_fix
branch
from
974656f to
21d778b
Compare
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Fixes #85743.
The color picker would update the current color to match the HTML string whenever the parsed value did not match the current color. Since Godot Colors have a 16 bit resolution, this would quantize the current value to the nearest HTML color even when no change was made. And since this happened whenever the HTML input lost focus, just opening and closing the color picker was enough to change a 16-bit value to the nearest 8-bit value.
With this PR, the HTML input only updates the current color when the HTML representation is different from the current color's HTML representation (and not whenever the HTML representation represents a different color than the current one).