Fix invalid Python escape sequences #85818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Dec 6, 2023
akien-mga
added
bug
topic:buildsystem
cherrypick:3.x
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Many thanks! 🥳 |
|
Cherry-picked for 4.2.1. |
akien-mga
removed
the
cherrypick:4.2
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.4. |
akien-mga
removed
the
cherrypick:3.5
|
Cherry-picked for 4.1.4. |
akien-mga
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python leaves the backslash in invalid escape sequences so the results have so far functioned the same as properly escaping the backslashes. In Python 3.12 this causes SyntaxWarnings but future Python versions will raise SyntaxErrors (https://docs.python.org/3/whatsnew/3.12.html).
Running
% pycodestyle --select W605 $(find godot/ -name "*.py")to find offending code yields:
This PR fixes all those issues by escaping the backslash.