Fix particle spread values affecting particle velocity #85880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rudolph-B
changed the title
akien-mga
added
cherrypick:4.2
clayjohn
reviewed
Dec 7, 2023
|
Other than my comment, everything else looks good. The rest matches what we had in 4.1. So this PR should be good to go as long as we aren't introducing a behaviour change to 3D now |
Rudolph-B
force-pushed
the
GPU-particles-2D-spread-issue
branch
from
c5ccf66 to
6b2a1b4
Compare
AThousandShips
changed the title
|
Would superseed #86233 |
|
Yep sorry. I have seen this PR only after opening my PR that supersedes the other one. I havent tested this one yet |
|
@QbieShay Is there any tests in particular that I can run that can help? |
|
I tested this PR with my particle system from 4.1.2 and #85620 looks to be fixed. Did you have a 2D test case where there are still issues compared to 4.1.x? |
|
This is the original MRP for #85744 |
Rudolph-B
force-pushed
the
GPU-particles-2D-spread-issue
branch
from
dcaf6d3 to
6b2a1b4
Compare
clayjohn
approved these changes
Apr 23, 2024
This was referenced Apr 23, 2024
akien-mga
changed the title
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #85744 and partially #85620
The spread direction vector for a particle had affected the particles velocity. This was caused by
spread_directionnot being normalized before it was returned fromget_random_direction_from_spread(). A compounding issue to this was thatget_random_direction_from_spread()still generated a 3Dspread_directioneven whenPARTICLE_FLAG_DISABLE_Zis set.I made changes to
get_random_direction_from_spread()so that it:spread_directionbefore returning it.