Fix RegEx.sub truncating string when end is used
#86052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
RegEx.sub truncating string when end is used
akien-mga
changed the title
RegEx.sub truncating string when end is usedRegEx.sub truncating string when end is used
akien-mga
added
bug
topic:core
cherrypick:4.2
TheSofox
force-pushed
the
regex-sub-fix
branch
from
0cb7201 to
46b420f
Compare
|
I've added some Unit Tests for this fix. |
akien-mga
approved these changes
Feb 20, 2024
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55067
When the
endargument ofRegEx.subwas used, it would truncate the Subject String before even doing the substitution. This fix ensures the end of the subject string is reattached, so that the function works as expected.