Reset TileMap editor drag_type when the toolbar mode is not selected
#86066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
akien-mga
added
the
cherrypick:4.2
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
akien-mga
changed the title
drag_type when the toolbar mode is not selected
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you so much for all your help, haha. I don't really understand how all those other commits showed up, but all's well that ends well |
groud
requested changes
Dec 14, 2023
|
Looks good. Could you please squash the commit together ? |
…on when the toolbar mode is not selected
Done! |
groud
approved these changes
Dec 14, 2023
|
Thanks, and congrats on your first merged Godot contribution! |
YuriSizov
removed
the
cherrypick:4.2
|
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes : #85077
The problem made it so that the drag_type was kept until the toolbar mode SELECT was once again pressed. This made it so tilemap was drawing automatically without having to press down the left mouse button. By changing drag type to none when select is not used, this is fixed.