Fix Popup hover and height calculation are off by some pixels #86141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by an incorrect calculation of the v_separation where it was not needed
KoBeWi
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Well I can confirm that PopupMenu is quite glitchy before this fix (e.g. try shrinking PopupMenu with 2 items and 0 separation. It will show the scrollbar...). Though the old code does not look obviously wrong to me, so I can't say how correct is the fix. It does not seem to break anything at least.
YuriSizov
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Makes sense. It looks like modified code treated separation as an external element, something added in between items. But we clearly use the separation as a part of each item. This may be inconsistent with other GUI elements, but that's another topic. For fixing the bugs this all makes sense and does work.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #86140
This was caused by an incorrect calculation of the
v_separationwhere it was not needed.To better understand the issue, this is how the
v_separationis used:Every item has a top separation of 5, and a bottom separation of 5 (
v_separation= 10).Therefore the following statement is true: 1x item has 1x
v_separation, which is also the fix for both calculation issues.