Include name field in MethodInfo operator ==

[TitanNano]

The GDScript analyzer currently does not recognize Methods from other scripting languages as callable. This is caused by this section of the analyzer:

godot/modules/gdscript/gdscript_analyzer.cpp

Lines 5014 to 5016 in 2d0ee20

	MethodInfo info = base_script->get_method_info(function_name);
	if (!(info == MethodInfo())) {

Which uses either ScriptExtension::get_method_info which calls MethodInfo::from_dict that never sets a MethodInfo.id,

godot/core/object/script_language_extension.h

Lines 105 to 109 in 2d0ee20

	virtual MethodInfo get_method_info(const StringName &p_method) const override {
	Dictionary mi;
	GDVIRTUAL_REQUIRED_CALL(_get_method_info, p_method, mi);
	return MethodInfo::from_dict(mi);
	}

or CSharpScript::get_method_info which doesn't set an ID either.

godot/modules/mono/csharp_script.cpp

Lines 2349 to 2374 in 2d0ee20

	for (int i = 0; i < methods_array.size(); i++) {
	Dictionary method_info_dict = methods_array[i];
	StringName name = method_info_dict["name"];
	MethodInfo mi;
	mi.name = name;
	Array params = method_info_dict["params"];
	for (int j = 0; j < params.size(); j++) {
	Dictionary param = params[j];
	Variant::Type param_type = (Variant::Type)(int)param["type"];
	PropertyInfo arg_info = PropertyInfo(param_type, (String)param["name"]);
	arg_info.usage = (uint32_t)param["usage"];
	if (param.has("class_name")) {
	arg_info.class_name = (StringName)param["class_name"];
	}
	mi.arguments.push_back(arg_info);
	}
	mi.flags = (uint32_t)method_info_dict["flags"];
	p_script->methods.set(push_index++, CSharpMethodInfo{ name, mi });
	}

Following the implementation of operator< I have therefore extended the equality operator to compare the name field as well.

(this fix is also compatible with at least 4.2 and 4.1)

[zaevi]

Related to #86256

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 4.2.2.

[raulsntos]

@akien-mga Should likely cherry-pick #86972 as well, since it's a follow-up. For context, it fixes #86256 (comment).

[paulloz]

This change is breaking interop for overloaded methods. I'm opening a dedicated issue.

Edit: See the issue linked below.