Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Android: Update the logic used to start / stop the GL thread #86380

Merged

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Dec 21, 2023

Currently the GL thread is started / stopped when the activity is respectively resumed / paused. However, according to the GLSurfaceView documentation, this should be done instead when the activity is started / stopped, so this change updates the start / stop logic for the GL thread to match the documentation.

4.x version

Currently the GL thread is started / stopped when the activity is respectively resumed / paused. However, according to the `GLSurfaceView` documentation, this should be done instead when the activity is started / stopped, so this change updates the start / stop logic for the GL thread to match the documentation.
@m4gr3d m4gr3d added this to the 3.6 milestone Dec 21, 2023
@m4gr3d m4gr3d requested a review from a team as a code owner December 21, 2023 04:43
@akien-mga akien-mga changed the title [3.x] Update the logic used to start / stop the GL thread [3.x] Android: Update the logic used to start / stop the GL thread Jan 5, 2024
@akien-mga akien-mga merged commit 2b7e00f into godotengine:3.x Jan 5, 2024
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the update_render_thread_paused_timing_3x branch January 5, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants