Always call _can_handle() before _parse_property()
#86467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
changed the title
_can_handle() before _parse_property()
akien-mga
approved these changes
Jun 26, 2024
|
Needs a rebase. |
KoBeWi
force-pushed
the
aliens_in_my_inspector
branch
from
6f1c784 to
f0da5ca
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some custom inspectors, like array inspector or TileSet inspector, used
instantiate_property_editor(), which had a different path for handling properties that did not usecan_handle(). This PR adds a proper check and also prevents passingnullas object for the method (as it can lead to crash when checking class).Fixes #71236