Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect CAMERA_DIRECTION_WORLD calculation #86516

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix incorrect CAMERA_DIRECTION_WORLD calculation #86516

merged 1 commit into from
Jul 18, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #86502

@jsjtxietian jsjtxietian requested a review from a team as a code owner December 26, 2023 06:10
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 26, 2023
acarx
acarx approved these changes Apr 26, 2024
View reviewed changes
Copy link

@acarx acarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in my custom billboard shader, INV_VIEW_MATRIX[2].xyz is the right value.

@akien-mga akien-mga changed the title Fix incorrect CAMERA_DIRECTION_WORLD calculation Fix incorrect CAMERA_DIRECTION_WORLD calculation May 29, 2024
@akien-mga akien-mga merged commit 590628f into godotengine:master Jul 18, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the fix-camera-direction branch July 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarx acarx acarx approved these changes

@clayjohn clayjohn clayjohn approved these changes

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

CAMERA_DIRECTION_WORLD shader built-ins does not yield the expected results
5 participants
@jsjtxietian @akien-mga @acarx @clayjohn @AThousandShips