Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LightmapperRD division warning in MSVC #86555

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix LightmapperRD division warning in MSVC #86555

merged 1 commit into from
Jan 4, 2024

Conversation

RandomShaper
Copy link
Member

This one (MSVC 14.3):

modules\lightmapper_rd\lightmapper_rd.cpp(360) : error C2220: the following warning is treated as an error
modules\lightmapper_rd\lightmapper_rd.cpp(360) : warning C4723: potential divide by 0

The value can't be zero with the expected values of the variables involved, though.

@RandomShaper RandomShaper added this to the 4.3 milestone Dec 27, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner December 27, 2023 16:52
@RandomShaper RandomShaper mentioned this pull request Dec 28, 2023
Merged
@akien-mga akien-mga changed the title Fix warning in MSVC Fix LighmapperRD division warning in MSVC Jan 3, 2024
@akien-mga akien-mga changed the title Fix LighmapperRD division warning in MSVC Fix LightmapperRD division warning in MSVC Jan 3, 2024
@akien-mga akien-mga merged commit 2a4eaa4 into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_warn branch January 5, 2024 12:42
@AThousandShips AThousandShips added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 23, 2024
@AThousandShips AThousandShips mentioned this pull request Feb 24, 2024
Merged
@akien-mga akien-mga added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Feb 25, 2024
@AThousandShips AThousandShips mentioned this pull request Feb 27, 2024
Merged
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Feb 27, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

@akien-mga akien-mga Awaiting requested review from akien-mga

Assignees
No one assigned
Labels
bug topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@RandomShaper @akien-mga @clayjohn @AThousandShips