Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sorting of enum autocompletion #86667

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Improve sorting of enum autocompletion #86667

merged 1 commit into from
Jan 4, 2024

Conversation

HolonProduction
Copy link
Member

Closes godotengine/godot-proposals#7913

The enum constants will now appear before methods. Also they are sorted in their declaration order and not alphabetical.

@HolonProduction HolonProduction requested a review from a team as a code owner December 31, 2023 13:36
@tokengamedev
Copy link

can this be merged to 4.2 also

@Mickeon
Copy link
Contributor

Mickeon commented Dec 31, 2023 •
edited
Loading

I don't see why this can't be cherrypicked for 4.2, so yes.

@dalexeev dalexeev added this to the 4.3 milestone Dec 31, 2023
ajreckof
ajreckof approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@ajreckof ajreckof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is pretty simple and straightforward. Seems to work.

LGTM

akien-mga
akien-mga approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 4, 2024
@akien-mga akien-mga merged commit 525e0bb into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

@HolonProduction HolonProduction deleted the completion-enum-sorting branch October 5, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajreckof ajreckof ajreckof approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gdscript usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Always display enum values first when autocompleting an enum
7 participants
@HolonProduction @tokengamedev @Mickeon @akien-mga @YuriSizov @ajreckof @dalexeev