-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display functions that were previously forgotten in Profiler #86772
Display functions that were previously forgotten in Profiler #86772
Conversation
The array data in `add()` contains these data, but some data may have been forgotten to be converted into `ServerFunctionInfo`. This results in some information not being displayed in the Profiler.
ef8d6a8
to
3d3c4e8
Compare
What would be the frame order? |
Line 3748 in fbaab3c
Line 3771 in fbaab3c
The array data is sorted and passed when calling godot/servers/physics_2d/godot_physics_server_2d.cpp Lines 1350 to 1358 in fbaab3c
So in a sense, the current data is also sorted according to chronological order. |
What's currently preventing this PR being merged? Would like to see this added as this also fixes usage of EngineDebugger.profiler_add_frame_data (Currently, only a single call will ever display using this method) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work 🏆
Thanks! |
Cherry-picked for 4.2.2. |
The array data in
add()
contains these data, but some data may have been forgotten to be converted intoServerFunctionInfo
.This results in some information not being displayed in the Profiler.
Should the display of these functions be reordered? According to the order in the same frame. 🤔