Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid several null-dereferences of ApiContextRD #86843

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Avoid several null-dereferences of ApiContextRD #86843

merged 1 commit into from
Feb 7, 2024

Conversation

RandomShaper
Copy link
Member

Fixes #86436.

@RandomShaper RandomShaper added this to the 4.3 milestone Jan 5, 2024
@RandomShaper RandomShaper requested review from a team as code owners January 5, 2024 17:28
AThousandShips
AThousandShips approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, logical changes (assuming the get_api_name doesn't have some memory concerns in its turn)

@AThousandShips AThousandShips mentioned this pull request Jan 31, 2024
Merged
@RandomShaper RandomShaper force-pushed the fix_null_ptr branch 3 times, most recently from 431ec43 to bb0940c Compare February 6, 2024 17:10
@RandomShaper
Copy link
Member Author

@AThousandShips, thanks for helping me fixing the loose ends my eyesight seems not to want to detect. Hope it's OK now.

@akien-mga akien-mga merged commit 4f478a5 into godotengine:master Feb 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_null_ptr branch February 7, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Riteo Riteo Riteo approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug crash topic:porting topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Null pointer dereference in X11 initialization error message
4 participants
@RandomShaper @akien-mga @Riteo @AThousandShips