-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple of enhancements to user-visible threading semantics #86957
Conversation
CC @SlugFiller |
Cool! Nice to see things are happening quickly. Here's hoping it gets merged soon. |
Did you test it, do you approve it? 🙃 |
With just the first commit, I hit the same deadlock in running With both commits, and |
@SlugFiller, thank you for the feedback. I'm wondering, what happens if you override but return |
When returning |
I've fixed a very silly mistake causing infinite recursion if the method is not overridden. Please test again with |
Poofing is gone, and returning |
Thanks! |
Kept in two commits because, regardless both related to threading, the changes are heavily unrelated otherwise.
I'd appreciate especially careful reviewing of my
GDVIRTUAL
changes, as this is the first time I deal with that.