Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vulkan: Update components to Vulkan SDK 1.3.268.0 #87091

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented Jan 11, 2024

Google Inc seems to be removed from vk_enum_string_helper.h, therefore I also removed from COPYRIGHT.txt. The file was also moved from the Vulkan-ValidationLayers repo to Vulkan-Utility-Libraries.

All components' versioning now begin with "vulkan-".

All patches have been reapplied.

@DeeJayLSP DeeJayLSP requested a review from a team as a code owner January 11, 2024 23:36
@akien-mga akien-mga added this to the 4.3 milestone Jan 12, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Probably worth testing by @godotengine/rendering and on differently platforms (notably @godotengine/macos) to make sure everything works as expected.

@akien-mga
Copy link
Member

Tested briefly on Linux with AMD Radeon RX Vega M (amdgpu/radv drivers), it seems to work fine for me.

@akien-mga akien-mga merged commit a3976bc into godotengine:master Jan 15, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@DeeJayLSP DeeJayLSP deleted the vulkan-268 branch January 15, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants