-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul Quaternion documentation #87181
Overhaul Quaternion documentation #87181
Conversation
4de70fa
to
e3f49d8
Compare
A great resource I just found https://github.com/iwatake2222/rotation_master |
Definitely looks like a great website. However, as far as introductions go, it's extremely unfriendly. There's a lot data present all at once. The web version could be added as another link in the tutorial section, perhaps. |
e3f49d8
to
63d7c76
Compare
63d7c76
to
c52740f
Compare
Please do! |
It's done in the current version of this PR |
Man I wish this was a thing a week ago when I took on handling quaternion code in rust's gdextension. That being said. I've got a few things I discovered that aren't covered here. #87422. I propose that I merge after yours to incorporate the nitty gritty of what happens when you break the rules. |
I wanted to mention that the JPL and HAMILTON conversions differ by x*-1,y*-1,z*-1,w. Assuming that w is the real. Sometimes x is the real component. Like one. I am certain this is incomprehensible :( |
I have understood it in part from the sources I looked up. I am still struggling to visualize the difference in practice, however, as well as providing a simpler explanation to fit in Quaternion's description. Hence I cannot tell if the provided websites use the same convention as Godot or not. |
c52740f
to
c0e4dde
Compare
c0e4dde
to
d945196
Compare
I have once and for all clarified it's the Hamilton convention. Now, for more to review if there is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I urge you to please test things and review your work for factual accuracy. Nicer wording is useless if the words are not correct.
f5b4853
to
cfaa24c
Compare
I took all of the feedback at heart and addressed it. Hopefully I have not forgotten anything. |
cfaa24c
to
15cd23f
Compare
15cd23f
to
cdfb05a
Compare
cdfb05a
to
38cd13c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks! |
Cherry-picked for 4.2.2. |
Closes godotengine/godot-docs#6271
This PR aims to completely overhaul the Quaternion type.
The reasoning and changelog are extremely similar to the "Overhaul Basis Documentation" PR, so I'm not sure I should bother repeating them twice.
More specific notes:
I started this ASAP after seeing the "overwhelmingly" positive reception of the prior PR after a few mere hours. Feedback is very, very welcome. Quaternions are a very complicated concept to digest and comprehend.
This PR may contain multiple versions of the same line I was not sure about, denoted with "??". Reviewing of these lines is heavily appreciated.
Sources: