-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize SceneTree's change_scene_to_file
autocompletion
#87197
Merged
akien-mga
merged 1 commit into
godotengine:master
from
Mickeon:autocompletion-SceneTree-change-packed-to-file
Mar 1, 2024
Merged
Optimize SceneTree's change_scene_to_file
autocompletion
#87197
akien-mga
merged 1 commit into
godotengine:master
from
Mickeon:autocompletion-SceneTree-change-packed-to-file
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
autocompletion-SceneTree-change-packed-to-file
branch
from
January 15, 2024 00:33
14d2e8d
to
4d1309e
Compare
Mickeon
force-pushed
the
autocompletion-SceneTree-change-packed-to-file
branch
from
February 26, 2024 15:27
4d1309e
to
b1bf016
Compare
Chubercik
approved these changes
Feb 26, 2024
KoBeWi
reviewed
Feb 29, 2024
KoBeWi
reviewed
Feb 29, 2024
Mickeon
force-pushed
the
autocompletion-SceneTree-change-packed-to-file
branch
from
February 29, 2024 20:03
b1bf016
to
ba3dbd9
Compare
KoBeWi
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in my project with 1000+ scenes and this makes a nice speedup.
Needs a rebase. |
Mickeon
force-pushed
the
autocompletion-SceneTree-change-packed-to-file
branch
2 times, most recently
from
March 1, 2024 14:08
c7d5212
to
f1a41f9
Compare
All good now |
AThousandShips
approved these changes
Mar 1, 2024
Mickeon
force-pushed
the
autocompletion-SceneTree-change-packed-to-file
branch
from
March 1, 2024 14:12
f1a41f9
to
7b3e1a5
Compare
All gooder now. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is currently, the autocompletion for the SceneTree's
change_scene_to_file
is handled withinget_argument_options
. The implementation is done using a DirAccess and iterating through every file recursively, every time. It turns out this has a few problems:.glb
files)."text_editor/completion/complete_file_paths"
Editor Setting.This PR moves the autocompletion code out of the SceneTree and into the autocompletion code itself, recycling an existing function to go around all imported PackedScenes. This uses of the editor's own EditorFileSystem and is overall more performant.
In the future, this code snippet can even be further expanded with other similar methods.