-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace some "uncommon" words in class reference #87223
Merged
akien-mga
merged 1 commit into
godotengine:master
from
Mickeon:documentation-uncommon-words
Jan 16, 2024
Merged
Replace some "uncommon" words in class reference #87223
akien-mga
merged 1 commit into
godotengine:master
from
Mickeon:documentation-uncommon-words
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
documentation
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
labels
Jan 15, 2024
AThousandShips
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
Mickeon
force-pushed
the
documentation-uncommon-words
branch
from
January 15, 2024 16:40
743b543
to
68d651b
Compare
YuriSizov
reviewed
Jan 15, 2024
YuriSizov
reviewed
Jan 15, 2024
YuriSizov
reviewed
Jan 15, 2024
YuriSizov
reviewed
Jan 15, 2024
Other than that, seems like a nice cleanup! |
Mickeon
force-pushed
the
documentation-uncommon-words
branch
from
January 15, 2024 17:21
68d651b
to
b461b1d
Compare
Thank you @AThousandShips and @YuriSizov for taking your time looking at this! |
YuriSizov
reviewed
Jan 15, 2024
YuriSizov
approved these changes
Jan 15, 2024
Mickeon
force-pushed
the
documentation-uncommon-words
branch
from
January 15, 2024 17:51
b461b1d
to
61bdbdd
Compare
Thanks! |
YuriSizov
removed
cherrypick:4.1
Considered for cherry-picking into a future 4.1.x release
cherrypick:4.2
Considered for cherry-picking into a future 4.2.x release
labels
Jan 24, 2024
Cherry-picked for 4.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over time some very "exotic" words have seeped through the class reference. This is not very good because the assumption is that non-native English speakers should be able to read the documentation, as well.
When it can be done, it's better to be consistent. Broad terms and less common words relative to the rest of the class reference should be avoided.
This PR may seem big, but don't be fooled. Most of these words can only be found twice at most across the class reference, anyway. Some typos on the way are fixed, as well.
The most notable replacements include: