Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Fix MoltenVK SDK detection after file location changes in 1.3.275.0. #87305

Merged
merged 1 commit into from
Jan 17, 2024
Merged

[macOS] Fix MoltenVK SDK detection after file location changes in 1.3.275.0. #87305

merged 1 commit into from
Jan 17, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 17, 2024

The /MoltenVK folder in the root of the SDK has been removed. This folder contained duplicate headers that are found in /macOS/include. The MoltenVK specific internal headers have been moved to /macOS/include as well so that all required headers for Vulkan development on Apple platforms are in one location. In additon, the libraries and .xcFramework in /MoltenVK has been moved to macOS/lib, so that again, all libraries needed for macOS development are in one location.

@bruvzg bruvzg added this to the 4.3 milestone Jan 17, 2024
@bruvzg bruvzg requested a review from a team as a code owner January 17, 2024 17:34
@YuriSizov YuriSizov merged commit 96296e4 into godotengine:master Jan 17, 2024
14 of 15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 18, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 18, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 18, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.0.5. (If it ever happens :))

rsubtil pushed a commit to retrohub-org/godot that referenced this pull request Feb 4, 2024
@bruvzg @rsubtil
Cherry-pick godotengine#87305
0f9a42c 
[macOS] Fix MoltenVK SDK detection after file location changes in 1.3.275.0.
littlestray pushed a commit to littlestray/godot that referenced this pull request Feb 9, 2024
@YuriSizov @littlestray
Merge pull request godotengine#87305 from bruvzg/mvk_detect_new
23ab010 
[macOS] Fix MoltenVK SDK detection after file location changes in 1.3.275.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug platform:macos topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @YuriSizov @akien-mga