Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Use SymbolEqualityComparer #87342

Merged
merged 1 commit into from
Feb 15, 2024
Merged

C#: Use SymbolEqualityComparer #87342

merged 1 commit into from
Feb 15, 2024

Conversation

raulsntos
Copy link
Member

Use SymbolEqualityComparer to compare symbols and fix RS1024 warning.

@raulsntos raulsntos added this to the 4.3 milestone Jan 18, 2024
@raulsntos raulsntos requested a review from a team as a code owner January 18, 2024 15:59
@raulsntos raulsntos mentioned this pull request Jan 18, 2024
Closed
3 tasks
@van800 van800 mentioned this pull request Jan 20, 2024
Merged
paulloz
paulloz approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Ran tests locally, and no issue to report.

@van800
Copy link
Contributor

van800 commented Feb 14, 2024

Sorry to bother, I am waiting for this pull request.

@akien-mga
Copy link
Member

Needs rebase.

@raulsntos
C#: Use SymbolEqualityComparer
7b34870 
Use `SymbolEqualityComparer` to compare symbols and fix `RS1024` warning.
@akien-mga akien-mga merged commit 1efc362 into godotengine:master Feb 15, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/warnings/RS1024 branch February 15, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulloz paulloz paulloz approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@raulsntos @van800 @akien-mga @paulloz