Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for negative buffer_size inside StreamPeerGZIP::start_(de)compression #87448

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Add check for negative buffer_size inside StreamPeerGZIP::start_(de)compression #87448

merged 1 commit into from
Mar 8, 2024

Conversation

nfrmtk
Copy link
Contributor

@nfrmtk nfrmtk commented Jan 21, 2024

Fixes #87399

@nfrmtk nfrmtk requested a review from a team as a code owner January 21, 2024 19:34
@AThousandShips AThousandShips added bug topic:core cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jan 21, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jan 21, 2024
@AThousandShips AThousandShips changed the title add check for negative buffer_size inside StreamPeerGZIP::start_(de)compression Add check for negative buffer_size inside StreamPeerGZIP::start_(de)compression Jan 21, 2024
@akien-mga akien-mga changed the title Add check for negative buffer_size inside StreamPeerGZIP::start_(de)compression Add check for negative buffer_size inside StreamPeerGZIP::start_(de)compression Mar 6, 2024
@akien-mga
Copy link
Member

Could you squash the commits? See PR workflow for instructions.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Mar 6, 2024
@nfrmtk nfrmtk force-pushed the check-buffer-size branch from f9c5246 to da88600 Compare March 8, 2024 14:50
@akien-mga akien-mga merged commit baf75d0 into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

akien-mga commented Mar 9, 2024 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 4.2.2.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

StreamPeerGZIP.start_compression randomly freezes Godot
3 participants
@nfrmtk @akien-mga @AThousandShips