Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ivec variants to multiview_uv for stereo rendering #87460

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Add ivec variants to multiview_uv for stereo rendering #87460

merged 1 commit into from
Jan 25, 2024

Conversation

BastiaanOlij
Copy link
Contributor

This PR adds ivec variants of the multiview_uv helper function to stereo rendering.

Fixes: #87365

@BastiaanOlij BastiaanOlij requested a review from a team as a code owner January 22, 2024 02:54
@BastiaanOlij BastiaanOlij self-assigned this Jan 22, 2024
@BastiaanOlij BastiaanOlij added this to the 4.3 milestone Jan 22, 2024
@BastiaanOlij BastiaanOlij mentioned this pull request Jan 22, 2024
Closed
@clayjohn
Copy link
Member

Looks like you forgot the other renderers. #87365 was reported on the Forward+ renderer

@BastiaanOlij
Copy link
Contributor Author

Looks like you forgot the other renderers. #87365 was reported on the Forward+ renderer

Frag, haste makes waste, because I've been working on the compatibility renderer all last week, I had filters set on my search to limit everything to the drivers/opengl folder. DUH!

@BastiaanOlij
Copy link
Contributor Author

@clayjohn ok, should be good now. Also this time I actually tested the OPs MRP on all 3 renderers without any crashing :)

@BastiaanOlij BastiaanOlij requested a review from clayjohn January 24, 2024 04:00
@BastiaanOlij
Copy link
Contributor Author

Note: on the related issue @CheesecakeCG verified this is now working properly.

clayjohn
clayjohn approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@YuriSizov YuriSizov merged commit 1b83e8a into godotengine:master Jan 25, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@akien-mga akien-mga changed the title Add ivec variants to multiview_uv for stereo rendering Add ivec variants to multiview_uv for stereo rendering Feb 6, 2024
@BastiaanOlij BastiaanOlij deleted the stereo_ivec branch February 27, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug topic:rendering topic:xr topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Using texelFetch on the screen texture with XR shaders enabled crashes Godot
3 participants
@BastiaanOlij @clayjohn @YuriSizov