Fix TextEdit IME issues #87479
Merged
Fix TextEdit IME issues #87479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested the big PR and found that the issue I deducted in #83795 has been fixed. So this PR likely still fixes it. |
Paulb23
reviewed
Jan 28, 2024
| } | ||
| text.invalidate_cache(get_caret_line(i), get_caret_column(i), true, t, structured_text_parser(st_parser, st_args, t)); | ||
| } | ||
| if (has_ime_text()) { |
There was a problem hiding this comment.
nit: _update_ime_text already checks has_ime_text
There was a problem hiding this comment.
If I don't check for it, it would run the other branch in _update_ime_text() and invalidates the text cache unnecessarily.
Mickeon
reviewed
Jan 29, 2024
akien-mga
approved these changes
Feb 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IME text is now applied before most actions, so editing text and changing carets won't cause issues.
IME is applied before the right click context menu appears, before using the edit menu for any operation, and when clicking elsewhere in the TextEdit.
Scrolling with the mousewheel is no longer blocked when the IME is open.
Updating the IME will adjust the view to the caret and update the IME window position.